fix: Fix availability blocking other extensions startup #23316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
reviewed
Jul 11, 2024
lib/extension/availability.ts
Outdated
| } | ||
|
|
||
| private removeFromPingQueue(device: Device): void { | ||
| const index = this.pingQueue.findIndex((d) => d.ieeeAddr === device.ieeeAddr); | ||
| index != -1 && this.pingQueue.splice(index, 1); | ||
| } | ||
|
|
||
| private availabilityEnabledEntities(): (Device | Group)[] { |
There was a problem hiding this comment.
This creates a double-loop since the result is also always for looping over. Best to leave it "in-place" without this function. Especially since one appears to only want devices, and the other both devices and groups, so we can optimize the loop in each case instead?
|
I also report that it is not working, neither clearing the cache nor trying from another PC, nor anything from the configuration. When rolling back to an older version, it works. Not with the new one. Please fix it. |
|
to return the backup point where the z2m version is 1.39.1-1 it works fine when I update again to version 1.40.1-1 I can't see the UI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the availability from blocking other extensions to startup when at least 1 device is unavailable on startup.
Fixes #23266