Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defaults]: Ratings Overlay Doesn't Use Percent Sign #1478

Closed
Mjsciarabba opened this issue Jun 24, 2023 · 5 comments
Closed

[Defaults]: Ratings Overlay Doesn't Use Percent Sign #1478

Mjsciarabba opened this issue Jun 24, 2023 · 5 comments
Assignees

Comments

@Mjsciarabba
Copy link

Link to File

overlays/ratings

Version Number

1.19.0

What branch are you on?

nightly

Describe the Bug

The ratings overlay will apply the proper number but won't add the percent at the end (for example, 72 vs 72%)

@meisnate12
Copy link
Member

the rating should only default to percent for rt_popcorn, rt_tomato, and tmdb are you using one of those you can change the style your self using rating#_style: "%" switch out the # with your rating number

@chazlarson
Copy link
Contributor

chazlarson commented Jun 26, 2023

Something has changed WRT this in nightly.

example config:

libraries:
  Movies:
    overlay_path:
    - reapply_overlays: true
    - pmm: ratings
      template_variables:
        rating1: audience
        rating1_image: rt_popcorn
        rating1_horizontal_offset: 60
        rating1_vertical_offset: 55

        vertical_position: top
    operations:
      mass_audience_rating_update: mdb_tomatoesaudience

latest:

docker run --rm -ti -v /opt/pmm/config:/config meisnate12/plex-meta-manager -c /config/rating-test.yml --run
image

nightly:

docker run --rm -ti -v /opt/pmm/config:/config meisnate12/plex-meta-manager:nightly -c /config/rating-test.yml --run
image

@ChristianMalazarte
Copy link

Agreed something has changed. I just started using nightly because - pmm: flixpatrol wasn't working, and it's been fixed in nightly. But the percentage is gone.

@JohnFawkes
Copy link
Contributor

Yes we are aware of this. Ratings is currently broken in nightly. Should be fixed in next nightly

@meisnate12
Copy link
Member

this should all be fixed in nightly now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants