Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watchtower): activate utxo watchers #1859

Merged
merged 13 commits into from
Jun 19, 2023
Merged

feat(watchtower): activate utxo watchers #1859

merged 13 commits into from
Jun 19, 2023

Conversation

caglaryucekaya
Copy link

@caglaryucekaya caglaryucekaya commented Jun 13, 2023

This PR makes use_watchers configuration true by default. This means that all nodes will broadcast a watcher message after the taker payment is sent if the swapped coins are supported by watchers (only UTXO for now). It also fixes a problem that caused the nodes to broadcast two watcher messages consecutively after the taker payment is sent. The configurations to test the UTXO watchers manually can be found here.

@rozhkovdmitrii
Copy link

rozhkovdmitrii commented Jun 13, 2023

Thank you for changes!

Could you also please link a related issue?

@caglaryucekaya caglaryucekaya added in progress Changes will be made from the author and removed under review labels Jun 13, 2023
@caglaryucekaya caglaryucekaya linked an issue Jun 13, 2023 that may be closed by this pull request
@caglaryucekaya caglaryucekaya added under review and removed in progress Changes will be made from the author labels Jun 13, 2023
rozhkovdmitrii
rozhkovdmitrii previously approved these changes Jun 15, 2023
@rozhkovdmitrii
Copy link

rozhkovdmitrii commented Jun 15, 2023

Great work, I like it, thank you !

rozhkovdmitrii
rozhkovdmitrii previously approved these changes Jun 15, 2023
shamardy
shamardy previously approved these changes Jun 16, 2023
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shamardy shamardy added in progress Changes will be made from the author and removed under review labels Jun 17, 2023
@shamardy shamardy added under review and removed in progress Changes will be made from the author labels Jun 19, 2023
@shamardy shamardy merged commit e9dac57 into dev Jun 19, 2023
@shamardy shamardy deleted the activate-utxo-watchers branch June 19, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement swap watcher nodes.
3 participants