forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(watchtower): activate utxo watchers #1859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for changes! Could you also please link a related issue? |
caglaryucekaya
added
in progress
Changes will be made from the author
and removed
under review
labels
Jun 13, 2023
caglaryucekaya
added
under review
and removed
in progress
Changes will be made from the author
labels
Jun 13, 2023
…tivate-utxo-watchers
rozhkovdmitrii
previously approved these changes
Jun 15, 2023
Great work, I like it, thank you ! |
rozhkovdmitrii
previously approved these changes
Jun 15, 2023
shamardy
previously approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
…tivate-utxo-watchers
caglaryucekaya
dismissed stale reviews from shamardy and rozhkovdmitrii
via
June 16, 2023 15:58
e1c39cd
shamardy
added
in progress
Changes will be made from the author
and removed
under review
labels
Jun 17, 2023
shamardy
added
under review
and removed
in progress
Changes will be made from the author
labels
Jun 19, 2023
shamardy
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
use_watchers
configuration true by default. This means that all nodes will broadcast a watcher message after the taker payment is sent if the swapped coins are supported by watchers (only UTXO for now). It also fixes a problem that caused the nodes to broadcast two watcher messages consecutively after the taker payment is sent. The configurations to test the UTXO watchers manually can be found here.