New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min volume rounding can result in error #2181

Closed

smk762 opened this issue Dec 12, 2022 · 0 comments

Collaborator

smk762 commented Dec 12, 2022 •

edited

Loading

Generally, it works. You can't start trade with Volume < maker min_volume Yet, there's an issue:

If you use exact trade volume == maker min_volume, where maker's min volume has more than 6 decimals, order will likely not match due to rounding:

@smk762 this PR seems to fix initial issue/report, we can also fix my problem as separate issue. What do you think?

Yeah, def needs to be fixed - will create issue for it and tackle at same time as #2180

Originally posted by @smk762 in #2170 (comment)

smk762 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment