conformance: HTTPRouteHeaderMatching test

[mlavacca]

Problem Statement

KIC ControlPlane is already HTTP core conformant; the test HTTPRouteHeaderMatching is part of it. We need to run such a core test successfully.

Acceptance Criteria

• The core test HTTPRouteHeaderMatching is successfully run.

[pmalek]

This is only supported on expressions Kong Gateway router flavor in KIC (ref: https://github.com/Kong/kubernetes-ingress-controller/blob/d8c30ad0bdf84b11f9f60bd2b164d7d9398f60b0/test/conformance/gateway_conformance_test.go#L24-L27)

In order to support this we'll need to

• change the default router flavor and set it via envs in DataPlane

  gateway-operator/internal/utils/dataplane/config.go

  Lines 15 to 40 in 5d2fa24

  	var KongDefaults = map[string]string{
  	"KONG_ADMIN_ACCESS_LOG": "/dev/stdout",
  	"KONG_ADMIN_ERROR_LOG": "/dev/stderr",
  	"KONG_ADMIN_GUI_ACCESS_LOG": "/dev/stdout",
  	"KONG_ADMIN_GUI_ERROR_LOG": "/dev/stderr",
  	"KONG_CLUSTER_LISTEN": "off",
  	"KONG_DATABASE": "off",
  	"KONG_NGINX_WORKER_PROCESSES": "2",
  	"KONG_PLUGINS": "bundled",
  	"KONG_PORTAL_API_ACCESS_LOG": "/dev/stdout",
  	"KONG_PORTAL_API_ERROR_LOG": "/dev/stderr",
  	"KONG_PORT_MAPS": "80:8000, 443:8443",
  	"KONG_PROXY_ACCESS_LOG": "/dev/stdout",
  	"KONG_PROXY_ERROR_LOG": "/dev/stderr",
  	"KONG_PROXY_LISTEN": fmt.Sprintf("0.0.0.0:%d reuseport backlog=16384, 0.0.0.0:%d http2 ssl reuseport backlog=16384", consts.DataPlaneProxyPort, consts.DataPlaneProxySSLPort),
  	"KONG_STATUS_LISTEN": fmt.Sprintf("0.0.0.0:%d", consts.DataPlaneStatusPort),
  	"KONG_ADMIN_LISTEN": fmt.Sprintf("0.0.0.0:%d ssl reuseport backlog=16384", consts.DataPlaneAdminAPIPort),
  	// MTLS
  	"KONG_ADMIN_SSL_CERT": "/var/cluster-certificate/tls.crt",
  	"KONG_ADMIN_SSL_CERT_KEY": "/var/cluster-certificate/tls.key",
  	"KONG_NGINX_ADMIN_SSL_CLIENT_CERTIFICATE": "/var/cluster-certificate/ca.crt",
  	"KONG_NGINX_ADMIN_SSL_VERIFY_CLIENT": "on",
  	"KONG_NGINX_ADMIN_SSL_VERIFY_DEPTH": "3",
  	}

• or provide 2 conformance reports: for expressions and traditional_compatible (as it's done in KIC)

[mlavacca]

Isn't expression the default router for KIC? In case we specify no router type, the expression one should be defaulted, or not?

[pmalek]

As per: https://docs.konghq.com/gateway/latest/reference/configuration/#router_flavor

The default is traditional_compatible. It's a default in Kong Gateway not in KIC. KIC only reads what's set on the Gateway via the Admin API: https://github.com/Kong/kubernetes-ingress-controller/blob/9b863786b5abc262987f3129b046a878511daec7/internal/manager/run.go#L107-L112.

We'd have to start setting this config value.