Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misdocumented breaking change in v3 #13203

Closed
1 task done
zwing99 opened this issue Jun 13, 2024 · 6 comments
Closed
1 task done

misdocumented breaking change in v3 #13203

zwing99 opened this issue Jun 13, 2024 · 6 comments
Labels
core/docs pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... stale

Comments

@zwing99
Copy link

zwing99 commented Jun 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Kong version ($ kong version)

3.0

Current Behavior

in 2.X if you defined target_path on the service it was ignored by the aws-lambda plugin and never prepended to the path set sent in the json payload to lambda

Expected Behavior

In 3.X if you define target_path on the service it is prepend and this is apparently expected. HOWEVER, this is a breaking change to those expecting the target_path to be ignored. Can the changelog be update to reflect that #9058 and #9129 are in fact breaking changes to the 3.0 release.

Steps To Reproduce

  1. Set target_path on service
  2. Use aws-lambda plugin in 2.x vs 3.x

Anything else?

Please update the docs.

@chronolaw
Copy link
Contributor

@oowl , I think that you are those PR's author, could you take a look at this issue? thanks.

@zwing99
Copy link
Author

zwing99 commented Jun 18, 2024

@oowl and @chronolaw any updates here? Others? My organization had to roll back our upgrade from 2 -> 3 because of this breaking change. We need to make changes to the config before we can upgrade. It is our fault for configuring kong incorrectly and depending on bad behavior. However, patching this bug is a breaking change and I am just hoping to help others to hopefully catch it when reviewing the changelog.

@StarlightIbuki
Copy link
Contributor

IMO, fixing a buggy behavior is not a breaking change. It's arguable whether we should consider fixing a bug used as a feature in a special case. @oowl votes for you and you need another vote to change the changelog.

@oowl
Copy link
Member

oowl commented Jul 11, 2024

IMO, fixing a buggy behavior is not a breaking change. It's arguable whether we should consider fixing a bug used as a feature in a special case. @oowl votes for you and you need another vote to change the changelog.

Agree, fixing a buggy behavior is not a breaking change. we do not add any break change log for bug fixes.

@chronolaw chronolaw added the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Jul 11, 2024
Copy link
Contributor

This issue is marked as stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Jul 26, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Dear contributor,

We are automatically closing this issue because it has not seen any activity for three weeks.
We're sorry that your issue could not be resolved. If any new information comes up that could
help resolving it, please feel free to reopen it.

Your contribution is greatly appreciated!

Please have a look
our pledge to the community
for more information.

Sincerely,
Your Kong Gateway team

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/docs pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... stale
Projects
None yet
Development

No branches or pull requests

4 participants