Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clustering/rpc): support rpc batching on dp side #14040

Merged
merged 50 commits into from
Jan 14, 2025
Merged

feat(clustering/rpc): support rpc batching on dp side #14040

merged 50 commits into from
Jan 14, 2025

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 20, 2024 •
edited
Loading

Summary

KAG-5934

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 20, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 21, 2024
@chronolaw chronolaw changed the title refactor(clustering/rpc): rpc under working refactor(clustering/rpc): support rpc batching Dec 22, 2024
@chronolaw chronolaw force-pushed the refactor/add_rpc_batching branch from 92b6976 to e47aa67 Compare December 23, 2024 07:17
@chronolaw chronolaw changed the title refactor(clustering/rpc): support rpc batching refactor(clustering/rpc): support rpc batching on dp side Dec 24, 2024
@chronolaw chronolaw marked this pull request as ready for review December 24, 2024 05:08
@chronolaw
Copy link
Contributor Author

chronolaw commented Dec 24, 2024 •
edited
Loading

Since this feature is hard to test, I will add it to concentrator in another PR.

@ADD-SP ADD-SP requested a review from Copilot January 3, 2025 03:28
Copilot
Copilot AI reviewed Jan 3, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • kong/clustering/rpc/socket.lua: Language not supported
@chronolaw chronolaw force-pushed the refactor/add_rpc_batching branch 2 times, most recently from fd48976 to 4a3d7fd Compare January 8, 2025 06:45
StarlightIbuki
StarlightIbuki approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blockers

kong/clustering/rpc/socket.lua Show resolved Hide resolved
kong/clustering/rpc/socket.lua Show resolved Hide resolved
@chronolaw chronolaw force-pushed the refactor/add_rpc_batching branch from edb1185 to 596ecba Compare January 12, 2025 22:55
ADD-SP
ADD-SP reviewed Jan 14, 2025
View reviewed changes
kong/clustering/rpc/manager.lua Outdated Show resolved Hide resolved
kong/clustering/rpc/manager.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP merged commit 1c2ea57 into master Jan 14, 2025
26 checks passed
@ADD-SP ADD-SP deleted the refactor/add_rpc_batching branch January 14, 2025 08:24
@chronolaw chronolaw changed the title refactor(clustering/rpc): support rpc batching on dp side feat(clustering/rpc): support rpc batching on dp side Jan 14, 2025
@ADD-SP
Copy link
Contributor

ADD-SP commented Jan 14, 2025

Please also cherry-pick to EE.

@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 14, 2025
This was referenced Jan 15, 2025
Merged
Merged
ADD-SP pushed a commit that referenced this pull request Jan 20, 2025
@chronolaw
feat(clustering/rpc): rpc batching on concentrator (#14055)
4448eef 
Sister PR: #14040

KAG-5934
ADD-SP pushed a commit that referenced this pull request Jan 22, 2025
@chronolaw
refactor(clustering/rpc): wait 5 seconds for rpc queue (#14189)
be10aa9 
In #14040 we changed the timeout from 5 to 0.5, but that is not necessary and may cause checking queue frequently,
so this PR revert this small change.

KAG-5934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@ADD-SP ADD-SP ADD-SP approved these changes

@Water-Melon Water-Melon Water-Melon approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/L skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @ADD-SP @chobits @Water-Melon @StarlightIbuki