fix(core): separate plugin server runtime data from kong configuration #14111
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProBrian
commented
Jan 9, 2025
xianghai2
approved these changes
Jan 15, 2025
|
Please hold on this one, I want to give it a try locally, thanks! |
gszr
reviewed
Jan 22, 2025
changelog/unreleased/kong/fix-admin-api-route-path-response-error.yml
Outdated
Show resolved
Hide resolved
gszr
approved these changes
Jan 22, 2025
github-actions
bot
added
core/language/go
core/language/python
core/language/js
cherry-pick kong-ee
gszr
force-pushed
the
fix/plugin-server-flaky
branch
from
0141f46 to
e5ca11b
Compare
|
@ProBrian please open a backport to Kong EE and request a review from me. Thanks! |
|
@ProBrian, could you update the PR subject to follow our commit message convention https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#commit-message-format? Thanks |
… which could not be cjson encoded
…e-path-response-error.yml
ProBrian
force-pushed
the
fix/plugin-server-flaky
branch
from
e5ca11b to
cad5004
Compare
ProBrian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem: There are some runtime data like
procstored inkong.configuration.pluginservers, which is cdata type and could not be encoded by cjson. Thus when fetching the admin api "/", the response body encoding of configuration will fail and throws 500 error.Solution: Separate runtime data from configuration, store runtime info like
procinside the plugin servers module, not global configuration.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix https://konghq.atlassian.net/browse/KAG-6088