fix(router): host matches should be case insensitive as per RFC 3986 #14198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC3986 (section 3.2.2) states that host header is case insensitive.
github-actions
bot
added
core/router
cherry-pick kong-ee
ms2008
force-pushed
the
feat/host-match-case-insensitive
branch
2 times, most recently
from
839b741 to
a9c5620
Compare
ms2008
force-pushed
the
feat/host-match-case-insensitive
branch
from
a9c5620 to
f085128
Compare
|
Still have a issue here is that when using expressions to configure routes, the expressions must be in lowercase. I still need to discuss the best solution with the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(router) host matches should be case insensitive as per RFC 3986
RFC3986 (section 3.2.2) states that host header is case insensitive.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6158