Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gha): use regctl for (multiarch) image copy #10335

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

curiositycasualty
Copy link
Contributor

Summary

This PR pivots the docker hub re-tagging portions of the release github action to utilize regctl image copy instead of plain ole' docker pull.
The docker pull approach lacked support for multi-architecture builds, result in only amd64 image tags being added to unofficial/official repos.

Sister PR to: https://github.com/Kong/kong-ee/pull/4624

Checklist

Full changelog

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 21, 2023
.github/workflows/release.yml Outdated Show resolved Hide resolved
@dndx dndx merged commit b5d01ec into master Feb 22, 2023
@dndx dndx deleted the build/regctl-copy branch February 22, 2023 02:56
@mashapedeployment
Copy link
Contributor

The backport to release/3.2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.2.x release/3.2.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.2.x
# Create a new branch
git switch --create backport-10335-to-release/3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b5d01ecbcfe6c990f49cee4d8279b4b4267c0373
# Push it to GitHub
git push --set-upstream origin backport-10335-to-release/3.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.2.x

Then, create a pull request where the base branch is release/3.2.x and the compare/head branch is backport-10335-to-release/3.2.x.

dndx added a commit that referenced this pull request Feb 22, 2023
Co-authored-by: Datong Sun <datong.sun@konghq.com>
dndx added a commit that referenced this pull request Feb 23, 2023
Co-authored-by: Datong Sun <datong.sun@konghq.com>
This was referenced Mar 16, 2023
curiositycasualty pushed a commit that referenced this pull request Oct 15, 2024
This relates to this Pongo release PR: Kong/kong-pongo#627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants