Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): update docs and Makefile to use Bazel build system #10442

Merged
merged 3 commits into from
Mar 14, 2023
Merged

feat(*): update docs and Makefile to use Bazel build system #10442

merged 3 commits into from
Mar 14, 2023

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Mar 7, 2023

@fffonion
Copy link
Contributor Author

fffonion commented Mar 7, 2023

thanks for the review!
but please hold for merge now, i just figured i need to do some small re-ordering. will address that shortly

@fffonion fffonion force-pushed the doc/build branch 4 times, most recently from 1152d64 to 70609e9 Compare March 8, 2023 09:18
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Mar 8, 2023
chronolaw
chronolaw reviewed Mar 8, 2023
View reviewed changes
DEVELOPER.md Outdated Show resolved Hide resolved
@fffonion fffonion force-pushed the doc/build branch 3 times, most recently from f1f05ed to e7c7622 Compare March 8, 2023 10:07
@chronolaw
Copy link
Contributor

Don't we need Gojira any more?

@fffonion fffonion force-pushed the doc/build branch 6 times, most recently from 6e0d18d to 952e645 Compare March 14, 2023 03:38
@fffonion fffonion changed the title docs(*): update docs to use Bazel build system feat(*): update docs and Makefile to use Bazel build system Mar 14, 2023
@fffonion
Copy link
Contributor Author

this can now be reviewed

@fffonion fffonion merged commit 93d88af into master Mar 14, 2023
@fffonion fffonion deleted the doc/build branch March 14, 2023 07:32
This was referenced Mar 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw left review comments

@dndx dndx dndx approved these changes

@hanshuebner hanshuebner hanshuebner approved these changes

Assignees
No one assigned
Labels
build/bazel chore Not part of the core functionality of kong, but still needed core/docs size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fffonion @chronolaw @hanshuebner @dndx @locao