Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow PATCH method on jwt credential endpoint" #665

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Revert "Allow PATCH method on jwt credential endpoint" #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions kong/plugins/jwt/api.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ return {
return helpers.responses.send_HTTP_OK(self.credential)
end,

PATCH = function(self, dao_factory)
crud.patch(self.params, self.credential, dao_factory.jwt_secrets)
end,

DELETE = function(self, dao_factory)
crud.delete(self.credential, dao_factory.jwt_secrets)
end
Expand Down
8 changes: 3 additions & 5 deletions spec/plugins/jwt/api_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,9 @@ describe("JWT API", function()

describe("PATCH", function()

it("[SUCCESS] should update a credential", function()
local response, status = http_client.patch(BASE_URL..jwt_secret.id, {key = "alice",secret = "newsecret"})
assert.equal(200, status)
jwt_secret = json.decode(response)
assert.equal("newsecret", jwt_secret.secret)
it("[SUCCESS] should not be supported", function()
local _, status = http_client.patch(BASE_URL..jwt_secret.id, {key = "alice"})
assert.equal(405, status)
end)

end)
Expand Down