Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission controller validates KongClusterPlugin #1764

Closed
1 of 3 tasks
rainest opened this issue Aug 26, 2021 · 1 comment · Fixed by #1961
Closed
1 of 3 tasks

Admission controller validates KongClusterPlugin #1764

rainest opened this issue Aug 26, 2021 · 1 comment · Fixed by #1961
Labels
bug Something isn't working priority/medium

Comments

@rainest
Copy link
Contributor

rainest commented Aug 26, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

The admission controller validates KongPlugins, but not KongClusterPlugins. The two resources are largely identical and could easily share validation logic.

Proposed Solution

  • Reuse the KongPlugin validation functions in a validator for KongClusterPlugin.
  • NamespacedConfigSource will require some wrapper to allow it to work with the KongPlugin validator.

Additional information

No response

Acceptance Criteria

  • The admission controller validates KongClusterPlugins
  • All validation failures for KongPlugins also result in failures for KongClusterPlugins with equivalent configuration.
@hhoover
Copy link

hhoover commented Oct 21, 2021

ran into this today when applying two KongClusterPlugins that conflicted. The API accepted the plugin config but didn't actually implement it in the ingress controller/proxy due to the conflict. The webhook should have rejected the conflicting object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants