Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve observability around config sync #6191

Closed
2 tasks done
lahabana opened this issue Jun 12, 2024 · 4 comments
Closed
2 tasks done

Improve observability around config sync #6191

lahabana opened this issue Jun 12, 2024 · 4 comments
Assignees
Labels
area/konnect Issues and PRs related to Konnect area/observability release/required it is required that this be resolved before releasing
Milestone

Comments

@lahabana
Copy link
Contributor

lahabana commented Jun 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

There are metrics to see how long sync takes: https://docs.konghq.com/kubernetes-ingress-controller/latest/production/observability/prometheus/#ingress_controller_configuration_push_duration_milliseconds

A user is suggesting adding this to logs.

logger.V(util.InfoLevel).Info("Successfully synced configuration to Konnect")

Is this something we want to do?

Proposed Solution

No response

Additional information

No response

Acceptance Criteria

  • Potentially log duration

Tasks

  1. area/observability
    randmonkey
  2. area/observability
    randmonkey
@lahabana lahabana added area/konnect Issues and PRs related to Konnect area/observability labels Jun 12, 2024
@lahabana lahabana added this to the KIC v3.3.x milestone Jun 12, 2024
@mheap
Copy link
Member

mheap commented Jun 12, 2024

The request is a little more involved. They'd like timings for each phase e.g.

  • Fetch from k8s API server
  • Translate to Kong format
  • Sync with Konnect

@lahabana lahabana added the release/required it is required that this be resolved before releasing label Jun 24, 2024
@lahabana
Copy link
Contributor Author

This looks a lot like tracing to me but tracing without an originator is a little unusual.

@lahabana lahabana modified the milestones: KIC v3.3.x, KIC v3.4.x Jun 28, 2024
@lahabana
Copy link
Contributor Author

Let's go for logs as a first step we can always improve later

@tao12345666333
Copy link
Member

I have previously attempted to add tracing support for KIC (for performance testing purposes).

previously proposal here: https://docs.google.com/document/d/1iSWDjODhupV-1GxIBCsDcXbyrAyMghl2zg9wKXMPRVU/edit?usp=sharing

Example

img

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect area/observability release/required it is required that this be resolved before releasing
Projects
None yet
Development

No branches or pull requests

4 participants