Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bug in v1.4.0-1, path.lua:501: attempt to concatenate a nil value #110

Closed
rushikeshz97 opened this issue Apr 1, 2024 · 6 comments
Closed

Comments

@rushikeshz97
Copy link

/usr/local/share/lua/5.1/pl/path.lua:501: attempt to concatenate a nil value
stack traceback:
/usr/local/share/lua/5.1/pl/path.lua:501: in function 'expanduser'
/usr/local/share/lua/5.1/resty/aws/config.lua:240: in function 'load_config'
/usr/local/share/lua/5.1/resty/aws/config.lua:289: in function 'get_config'
/usr/local/share/lua/5.1/resty/aws/config.lua:350: in function '__index'

Hi this is a new issue we have encountered in your recent update 1.4.0. Seems to be caused by the change at resty/aws/config.lua:240, where you call pl_path.expanduser(env_vars.AWS_CONFIG_FILE.value).

Regards
Rushikesh

Tieske added a commit to lunarmodules/Penlight that referenced this issue Apr 2, 2024
Tieske added a commit to lunarmodules/Penlight that referenced this issue Apr 2, 2024
@Tieske
Copy link
Member

Tieske commented Apr 2, 2024

@rushikeshz97 on what platform are you experiencing this? Looks to me that issue could only occur on Windows?

Have you tried setting up Nginx such that the HOME environment variable does not get cleared? (when Nginx forks its worker processes, by default it will clear the env vars for security reasons)

@windmgc
Copy link
Member

windmgc commented Apr 10, 2024

Hmm, a failure example after version bump also found here: https://github.com/Kong/kong/actions/runs/8627721759/job/23648513062?pr=12846
cc @Tieske

It seems we need a penlight bump to solve the issue? (We might need to pin penlight version in dependency list to >= 1.14.0)

@Tieske
Copy link
Member

Tieske commented Apr 15, 2024

yes, we'd need that. I have an open PR to check, and then I can probably cut a Penlight release.

Are there required timelines?

@windmgc
Copy link
Member

windmgc commented Apr 15, 2024

@Tieske We'll need this before the feature freeze of 3.7 of Kong gateway which should be 2 weeks later.

@Tieske
Copy link
Member

Tieske commented Apr 15, 2024

Penlight release PR; lunarmodules/Penlight#472

@Tieske
Copy link
Member

Tieske commented Apr 15, 2024

Penlight 1.14.0 has been released and should fix the issue. Closing this now. @rushikeshz97 please reopen if necessary.

@Tieske Tieske closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants