-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to electron 20 #5
Conversation
Looks like the electron builds are failing, I think we might need to update node-gyp/node-pre-gyp and/or nan? |
Lets hope its this:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5 +/- ##
==========================================
Coverage ? 93.51%
==========================================
Files ? 44
Lines ? 940
Branches ? 97
==========================================
Hits ? 879
Misses ? 41
Partials ? 20 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Errors from the Ubuntu builds seems related to this: electron/electron#35193
|
relevant error, issue and pr
|
required to update insomnia to electron 20