Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to electron 20 #5

Closed
wants to merge 5 commits into from
Closed

bump to electron 20 #5

wants to merge 5 commits into from

Conversation

jackkav
Copy link

@jackkav jackkav commented Sep 13, 2022

required to update insomnia to electron 20

@jackkav jackkav self-assigned this Sep 13, 2022
@jackkav jackkav requested a review from DMarby September 13, 2022 07:20
@jackkav jackkav marked this pull request as ready for review September 13, 2022 07:20
@DMarby
Copy link

DMarby commented Sep 13, 2022

Looks like the electron builds are failing, I think we might need to update node-gyp/node-pre-gyp and/or nan?

@jackkav
Copy link
Author

jackkav commented Sep 13, 2022

Lets hope its this:

/home/runner/.cache/node-gyp/20.0.0/include/node/node.h:27:2: error: #error "It looks like you are building this native module without using the right config.gypi. This normally means that you need to update electron-rebuild (>=3.2.8) or node-gyp (>=8.4.0) if you're building modules directly."

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@e526ca0). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop       #5   +/-   ##
==========================================
  Coverage           ?   93.51%           
==========================================
  Files              ?       44           
  Lines              ?      940           
  Branches           ?       97           
==========================================
  Hits               ?      879           
  Misses             ?       41           
  Partials           ?       20           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DMarby
Copy link

DMarby commented Sep 13, 2022

Errors from the Ubuntu builds seems related to this: electron/electron#35193

Lets hope its this:

/home/runner/.cache/node-gyp/20.0.0/include/node/node.h:27:2: error: #error "It looks like you are building this native module without using the right config.gypi. This normally means that you need to update electron-rebuild (>=3.2.8) or node-gyp (>=8.4.0) if you're building modules directly."

@jackkav
Copy link
Author

jackkav commented Sep 13, 2022

relevant error, issue and pr

no known conversion for argument 7 from ‘Nan::imp::Sig {aka int}’ to ‘v8::SideEffectType’
electron/electron#35193
nodejs/nan#943

@jackkav jackkav mentioned this pull request Sep 22, 2022
1 task
@jackkav jackkav closed this Oct 12, 2022
@jackkav jackkav deleted the electron-20 branch October 12, 2022 08:30
@jackkav jackkav reopened this Oct 12, 2022
@filfreire filfreire closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants