Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CVE analysis when DB cache or upstream cdn is live #141

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

saisatishkarra
Copy link
Collaborator

@saisatishkarra saisatishkarra commented Aug 16, 2024

Summary:

Fixes #140

Description:

  • Include graceful error / warning message based on cache / db availability
  • when enforcement / input build_fail is false, CVE analysis is skipped
  • when enforcement / input build_fail is true, CVE analysis will failed / error the he downstream caller

@saisatishkarra saisatishkarra requested a review from a team as a code owner August 16, 2024 19:04
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 16, 2024

Luacheck Report

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
4 tests ±0  4 ✅ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 71a5844. ± Comparison against base commit 7a3a7bd.

♻️ This comment has been updated with latest results.

@saisatishkarra saisatishkarra force-pushed the fix/sca-db-timeout branch 4 times, most recently from 5720c79 to eed0d63 Compare August 16, 2024 19:21
@pankajmouriyakong
Copy link
Contributor

huraaah @saisatishkarra

@saisatishkarra saisatishkarra force-pushed the fix/sca-db-timeout branch 3 times, most recently from fe3d008 to deb8edf Compare August 16, 2024 19:39
@saisatishkarra saisatishkarra requested a review from a team as a code owner August 16, 2024 19:39
@saisatishkarra saisatishkarra force-pushed the fix/sca-db-timeout branch 12 times, most recently from 34fa6f9 to a34a222 Compare August 16, 2024 20:59
Include graceful error / skip cve analysis for grype based on enforcement and db availability

Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
Copy link
Contributor

@pankajmouriyakong pankajmouriyakong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saisatishkarra saisatishkarra merged commit a213265 into main Aug 16, 2024
12 checks passed
@saisatishkarra saisatishkarra deleted the fix/sca-db-timeout branch August 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grype CDN failures leading to Timedout workflows
3 participants