Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-consumers): group form fields [KHCP-11029] #1300

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Mar 28, 2024

Summary

Changes:

  • bump kongponents version
  • wrap consumer identification fields in fieldset element and associate heading element to it using aria-labelledby attribute (screenshot)

Screenshot 2024-03-28 at 9 36 18 AM

Resources

@portikM portikM self-assigned this Mar 28, 2024
@portikM portikM requested review from kongponents-bot and a team as code owners March 28, 2024 13:39
@@ -21,7 +21,10 @@
:title="t('consumers.form.info.title')"
>
<div>
<h3 class="fields-group-title">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PR review: only changes besides kongponents version bump are in this file

@portikM portikM enabled auto-merge (squash) March 28, 2024 14:36
@portikM portikM merged commit c9375c0 into main Mar 28, 2024
31 checks passed
@portikM portikM deleted the fix/khcp-11029-consumer-form-a11y branch March 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants