-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expressions): add router-playground-modal [KM-299] #1497
Conversation
Zehao Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
76470af
to
f26aaff
Compare
packages/core/expressions/src/components/RequestImportModal.vue
Outdated
Show resolved
Hide resolved
f26aaff
to
171f98f
Compare
packages/core/expressions/src/components/RequestImportModal.vue
Outdated
Show resolved
Hide resolved
c16d749
to
ff6b79b
Compare
a9bd8c4
to
6760110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits and suggestions. Did not functional test
packages/entities/entities-routes/sandbox/pages/RouteFormPage.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-routes/sandbox/pages/RouteFormPage.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-routes/src/components/RouteFormExpressionsEditor.vue
Outdated
Show resolved
Hide resolved
c13b136
to
827a61a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think introducing the mix of packages that share cypress.config and another set op packages that requires it's of cypress config Is a mistake. This makes CI (already complicated) even more complicated.
This makes me as a developer trying to create new package even more confused - do I do it with my own config or do I use shared...
We need to find the way of doing it unified way. If it has to be cypress config for each package - let's do it for every package. Have shared config as a function and extend it for packages that are needed.
But let's keep CI and package structure universal.
@adamdehaven @ValeryG |
a4081f2
to
ad08840
Compare
ad08840
to
e351421
Compare
Rather than refactoring the test configuration, it may be better to write up a summary of why the current setup does not meet your needs, and let the Core UI team evaluate any changes we can implement so that it works better for everyone, rather than integrating changes for a specific package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did functionality tests and LGTM 🚀
We have some known issues in the router playground:
- HTTP headers in requests appeared as
[object Object]
in the exported JSON - Support HTTP headers with multiple values (should add context value per header value)
- Better ID handling while importing/exporting requests
- Missing VFG in the sandbox causing Vue warnings
As the main goal of this PR is to move the playground from kong-admin
to here, we can address them as separate follow-ups to avoid blocking this one. I've created KM-391 to track them.
Please hold off merging this until we have green CI in adoption PRs.
Tested functionality in Kong Manager and Konnect Gateway Manager. LGTM |
e351421
to
019debf
Compare
Summary
<RouterPlaygroundModal />
from kong-admin to public-ui<RouterForm />
and add some testswasm
andMonaco
vite plugins during the component tests running, which we should discuss with core UI team