Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): vault secret picker [KM-307] #1503

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat(*): vault secret picker [KM-307] #1503

merged 4 commits into from
Aug 7, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Jul 20, 2024 •
edited
Loading

Summary

core/forms

  • Autofill for fields in VFG
  • Remove showRemoveButton (It turned out this is no longer used after searching in the codebase)
  • Use backend schema for OIDC (verified)

entities/entities-plugins

  • Schema builder adoption
  • Autofill adoption
  • Tests

entities/entities-vaults

  • Export endpoints

entities/entities-shared

useDebouncedFilter

  • Reactivity fix
  • Support exact matching on the key field
  • Use cached response when the query is empty after the first fetch

KM-307

@sumimakito sumimakito force-pushed the KM-307-vault-secret-lookup branch 9 times, most recently from e465cbb to 2482881 Compare July 24, 2024 09:52
@sumimakito sumimakito force-pushed the KM-307-vault-secret-lookup branch 13 times, most recently from cee8025 to b032bfa Compare August 2, 2024 10:11
@sumimakito sumimakito force-pushed the KM-307-vault-secret-lookup branch from b032bfa to 9c4659d Compare August 5, 2024 07:58
@sumimakito sumimakito marked this pull request as ready for review August 5, 2024 08:07
@sumimakito sumimakito requested review from QueaT-kong and a team as code owners August 5, 2024 08:07
@sumimakito sumimakito force-pushed the KM-307-vault-secret-lookup branch 3 times, most recently from a402c80 to 8afffc1 Compare August 5, 2024 13:27
@sumimakito sumimakito force-pushed the KM-307-vault-secret-lookup branch from f47bd83 to 77f9de0 Compare August 7, 2024 04:27
Leopoldthecoder
Leopoldthecoder previously approved these changes Aug 7, 2024
View reviewed changes
@Leopoldthecoder Leopoldthecoder merged commit 697f238 into main Aug 7, 2024
33 checks passed
@Leopoldthecoder Leopoldthecoder deleted the KM-307-vault-secret-lookup branch August 7, 2024 08:48
@sumimakito sumimakito mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder