-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vfg): convert field-select + more tests [khcp-11336] #1584
Conversation
40bcd56
to
dbad74c
Compare
3773742
to
1d58deb
Compare
packages/core/forms/src/components/fields/__tests__/FieldSelect.cy.ts
Outdated
Show resolved
Hide resolved
Hi @kaiarrowood, for non-required select fields, previously we had a In this PR, the Could we either keep the Field schema for your reference: "algorithm": {
"default": "round-robin",
"description": "Which load balancing algorithm to use.",
"one_of":
[
"round-robin",
"lowest-latency",
"lowest-usage",
"consistent-hashing",
"semantic"
],
"type": "string"
} |
1d58deb
to
b465ed0
Compare
Thanks @Leopoldthecoder , I added this check for required on the |
Yes, that looks good to me. I've also pulled the packages in KM and did some manual tests. Merging this PR. |
Summary
Convert VFG
FieldSelect
to use Kongponents + add more VFG component test coverage.Addresses KHCP-11336.
Adoption PR (with passing E2Es): https://github.com/Kong/konnect-ui-apps/pull/4209
Resources