Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vfg): convert field-select + more tests [khcp-11336] #1584

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Aug 27, 2024

Summary

Convert VFG FieldSelect to use Kongponents + add more VFG component test coverage.
Addresses KHCP-11336.

Adoption PR (with passing E2Es): https://github.com/Kong/konnect-ui-apps/pull/4209

Resources

@kaiarrowood kaiarrowood self-assigned this Aug 27, 2024
@kaiarrowood kaiarrowood force-pushed the feat/khcp-11336-vfg-field-select branch 2 times, most recently from 40bcd56 to dbad74c Compare September 10, 2024 14:57
@kaiarrowood kaiarrowood force-pushed the feat/khcp-11336-vfg-field-select branch 4 times, most recently from 3773742 to 1d58deb Compare September 20, 2024 14:04
@kaiarrowood kaiarrowood marked this pull request as ready for review September 20, 2024 16:40
@kaiarrowood kaiarrowood enabled auto-merge (squash) September 20, 2024 19:09
@Leopoldthecoder
Copy link
Member

Hi @kaiarrowood, for non-required select fields, previously we had a No selection... option so that users can unselect the field:

Kapture 2024-09-23 at 11 38 31

In this PR, the No selection... option is gone:

image

Could we either keep the No selection... option, or make such fields clearable?

Field schema for your reference:

"algorithm": {
  "default": "round-robin",
  "description": "Which load balancing algorithm to use.",
  "one_of":
    [
      "round-robin",
      "lowest-latency",
      "lowest-usage",
      "consistent-hashing",
      "semantic"
    ],
  "type": "string"
}

@kaiarrowood kaiarrowood force-pushed the feat/khcp-11336-vfg-field-select branch from 1d58deb to b465ed0 Compare September 23, 2024 13:14
@kaiarrowood
Copy link
Contributor Author

Hi @kaiarrowood, for non-required select fields, previously we had a No selection... option so that users can unselect the field:

Kapture 2024-09-23 at 11 38 31 Kapture 2024-09-23 at 11 38 31

In this PR, the No selection... option is gone:

image Could we either keep the `No selection...` option, or make such fields `clearable`?

Field schema for your reference:

"algorithm": {
  "default": "round-robin",
  "description": "Which load balancing algorithm to use.",
  "one_of":
    [
      "round-robin",
      "lowest-latency",
      "lowest-usage",
      "consistent-hashing",
      "semantic"
    ],
  "type": "string"
}

Thanks @Leopoldthecoder , I added this check for required on the clearable prop. Does this meet the requirements?

image

@Leopoldthecoder
Copy link
Member

Yes, that looks good to me. I've also pulled the packages in KM and did some manual tests. Merging this PR.

@kaiarrowood kaiarrowood merged commit c57df8e into main Sep 24, 2024
12 checks passed
@kaiarrowood kaiarrowood deleted the feat/khcp-11336-vfg-field-select branch September 24, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants