Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): add index to deeply nested input id #1638

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(forms): add index to deeply nested input id #1638

merged 1 commit into from
Sep 19, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Sep 19, 2024 •
edited
Loading

Summary

Add missing index info to deeply nested input ID, e.g. targets in the ai-proxy-advanced plugin:

Before After
image image

KM-521

Resources

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review September 19, 2024 08:02
TT1228
TT1228 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@TT1228 TT1228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@Leopoldthecoder Leopoldthecoder merged commit 0bb5e3b into main Sep 19, 2024
12 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/nested-field-index branch September 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TT1228 TT1228 TT1228 approved these changes

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @TT1228