Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entities-key-sets): migrate entities-key-sets from shared-ui-components #686

Merged
merged 4 commits into from
Aug 10, 2023
Merged

feat(entities-key-sets): migrate entities-key-sets from shared-ui-components #686

merged 4 commits into from
Aug 10, 2023

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Aug 10, 2023

Summary

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@nekolab nekolab force-pushed the mig/entities-key-sets branch from e25893c to 7c5dcd1 Compare August 10, 2023 06:21
@nekolab
Copy link
Contributor Author

nekolab commented Aug 10, 2023

All admin tests passed

@nekolab nekolab marked this pull request as ready for review August 10, 2023 07:01
@nekolab nekolab requested review from kongponents-bot and a team as code owners August 10, 2023 07:01
Leopoldthecoder
Leopoldthecoder approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 1bf4f72 into main Aug 10, 2023
@Leopoldthecoder Leopoldthecoder deleted the mig/entities-key-sets branch August 10, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekolab @Leopoldthecoder