Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entitites): add consumer-credentials package #687

Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat(entitites): add consumer-credentials package #687

merged 1 commit into from
Aug 10, 2023

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Aug 10, 2023 •
edited
Loading

Summary

Adds entities-consumer-credentials. Verified here.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@Leopoldthecoder Leopoldthecoder force-pushed the feat/consumer-credentials branch 2 times, most recently from d5a57ec to 1ad2d74 Compare August 10, 2023 07:28
@Leopoldthecoder Leopoldthecoder force-pushed the feat/consumer-credentials branch from 1ad2d74 to 490d7ec Compare August 10, 2023 08:44
nekolab
nekolab approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 7fd6f32 into main Aug 10, 2023
@Leopoldthecoder Leopoldthecoder deleted the feat/consumer-credentials branch August 10, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekolab nekolab nekolab approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @nekolab