Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entities-routes): migrate entities-routes from shared-ui-components #699

Merged
merged 6 commits into from
Aug 14, 2023

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Aug 12, 2023

Summary

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@nekolab nekolab force-pushed the feat/migrate-entities-routes branch from af4824b to ddb0385 Compare August 12, 2023 08:35
@nekolab
Copy link
Contributor Author

nekolab commented Aug 12, 2023

Also tested in KM

@nekolab nekolab marked this pull request as ready for review August 12, 2023 10:37
@nekolab nekolab requested review from kongponents-bot and a team as code owners August 12, 2023 10:37
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 04277bc into main Aug 14, 2023
@Leopoldthecoder Leopoldthecoder deleted the feat/migrate-entities-routes branch August 14, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants