Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-certificates): use textarea for cert_alt and key_alt [FTI-5250] #809

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Sep 27, 2023

Summary

Using <KTextArea /> for cert_alt and key_alt fields to preserve the newlines (\n) in the PEM-encoded data.

Fixes FTI-5250

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR. n/a

@sumimakito sumimakito requested review from a team as code owners September 27, 2023 09:40
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sumimakito sumimakito merged commit eebc59a into main Sep 28, 2023
@sumimakito sumimakito deleted the fix/FTI-5250 branch September 28, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants