Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data fetching for better performance and UX #255

Closed
6 tasks done
Tracked by #232
nampc1 opened this issue May 11, 2022 · 5 comments
Closed
6 tasks done
Tracked by #232

Improve data fetching for better performance and UX #255

nampc1 opened this issue May 11, 2022 · 5 comments
Assignees
Milestone

Comments

@nampc1
Copy link

nampc1 commented May 11, 2022

Description:

  • - Caching data in chrome store
  • - Show most recent data instead of loading icon in case of connection failure
  • - Remove some cron and subscription jobs when idling
  • - Allow user to manually refresh data
  • - Add refresh button for network can't connect
  • - Add update endpoint button for network can't connect
@nampc1 nampc1 self-assigned this May 11, 2022
@nampc1 nampc1 changed the title Caching latest data (tokens, nfts, ...) in localStorage Improve data fetching for better performance and UX May 11, 2022
@hieudd hieudd added this to the Milestone 3 milestone Jun 1, 2022
@nampc1 nampc1 modified the milestones: Milestone 3, Milestone 2 Jun 1, 2022
@nampc1 nampc1 assigned huukhai and unassigned nampc1 Jun 2, 2022
@sokol142
Copy link

sokol142 commented Jun 3, 2022

After successful installation, check display of the transactions history.
Actual: Display transaction history incorrect (see file attachment below)

  • Switch from Account A to Account B but Transaction history still shows both Account A & Account B transactions
    image
    346_bug

@sokol142
Copy link

sokol142 commented Jun 27, 2022

Check issues:

  • Informations is incorrect when switch account in case turn on - turn off extension
    Steps:
  1. Open the extension (both expand & popup mode)
  2. Current Account = All Account
  3. Turn off the extension for 3 - 5 minutes
  4. Turn on the extension
  5. Switch form All Account to Account A
  6. Observe the information being displayed
    Actual: Still showing information of the All Account even though current account is Account A
    Expected: display data is correct
    255_cf
  • Still displaying NFT of the network which is inactive
    Steps:
  1. Open the extension & switch to any network (example: switch to Kusama)
  2. Go to NFTs tab then observe NFTs being displayed
  3. Go to Custom Network screen, then disconnect Kusama chain
  4. Back to NFT tabs then observe NFTs being displayed again
    Actual: Still displaying NFT
    255_cf_2
  • Displaying wrong information on balance, NFT,... when switching accounts after a period of opening without using extension
    Steps:
  1. Open the extension on expand mode
  2. Switch from Account A to Account B then observe the balance, tokens, NFTs,...
  3. Still open the extension but don't use it for 3 - 5 minutes
  4. Back to the extension, switch from Account B to Account A then check data being displayed
    Actual: Still showing information of the Account B even though current account is Account A
    225_Exxpandmode_SwitchAcc
  • Still showing sent NFT
    Steps:
  1. Open the extension on Firefox browser
  2. Switch to Account A & check the NFT is showing
  3. Open the extension on Chrome browser, still with Account A on, the user sends any NFT from Account A to another Account
  4. After send NFT successfully, back to Firefox browser then check NFT is showing
  5. Perform switch to another account then check NFT is showing
    Actual:
  • The sent NFT is still displayed in Account A
  • Even though the switch account is still showing the sent NFT
  • NFT is updated only when user performing Reload Extension
    image

@sokol142
Copy link

sokol142 commented Jun 28, 2022

Please check:

  • EVM chain balance updated continuously
    255_LoadBalance

  • Do not update the value of active stake / Unlocking stake after unstake successfully

  • it is displayed when the User switches to an account
    255_updateUnstakeBalance

Note for testing: Check this case after dev fixed bug "Still showing sent NFT"

  • The sender address shows wrong balance after send fund successfully
    Steps:
  1. Open the extension
  2. Switch to Account A and check its balance
  3. Go to the Send fund screen
  4. Select tokens = ROC then perform send fund successfully
  5. Back to Homepage & check this account's ROC balance
    Actual:
  • If the receiving address and sending address are on the same session then ROC balance = receipt address balance
  • If the receiving address and sending address are on the difference session then ROC balance = All balance
    Expected: Shows correct balance
    255_Wrongbalance

@sokol142
Copy link

sokol142 commented Jul 2, 2022

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./346-merge-build-0.4.7-1656662903820.zip
Pls check this issues:

  • EVM accounts update Sub-token, balance is delayed when user perform:
  • Switch Account
  • Turn on popup
  • Import tokens
  • Network Setting

See this file attachment: https://www.loom.com/share/e6bafbe5a51a4f3bae21cd3766c0bfec

@sokol142
Copy link

sokol142 commented Jul 25, 2022

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./346-merge-build-0.4.9-1656920983722.zip

Please check this issue:

  • Can not loading information in case the browser shuts down improperly

Steps:

  1. Open the expand extension on browser Brave
  2. Use extension
  3. Shut down the device (case: the browser shuts down improperly)
  4. Reopen your device & browser Brave
  5. Then observe the information displayed

Actual: Can not load the information

  • User must be reload extension or open the popup extension to load the information

Expected: Load & show correct information
(File record step 4, 5:
346_loading

Steps:

  1. Open the extension (For example, in the wallet already have NFT Moonbeast)
  2. Go to Manage EVm Tokens screen
  3. Select Moonbeast then delete token successfully
  4. Back to NFT Collection then observe list NFT collection displayed

Actual: Still show NFT Moonbeast

346_bug_deleteNFT.mp4

Expected: Not shows deleted NFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants