Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent code and language formatting #506

Open
nick-botticelli opened this issue Aug 21, 2024 · 1 comment
Open

Consistent code and language formatting #506

nick-botticelli opened this issue Aug 21, 2024 · 1 comment

Comments

@nick-botticelli
Copy link
Contributor

nick-botticelli commented Aug 21, 2024

Taking a peek at the codebase and strings these days I noticed a lot of inconsistent code syntax style/formatting (e.g., if (thing) vs. if(thing)). Though, I found a stale issue #422 about solving this already.

Additionally I have minor quibbles about certain terminology used in strings along the application. For example, Jar vs. JAR—Oracle and Wikipedia both use the styling of "JAR," so I think using that instead may be more proper. The same could also be said about ZIP, etc.

I also noticed the usage of two periods (..) versus three as a proper ellipses, which also raises the question whether three periods should be used (...), or Unicode's HORIZONTAL ELLIPSIS (…); personally, I like the latter.

Additionally I noticed that there may be some inconsistency with the grammar of translations. For example, in the Vietnamese translation file, many translation strings have a space before the ellipses but not the periods (e.g., "Lưu dưới dạng Zip ..." vs. "Mở..."). There also appear to be un-translated strings as well ("Save As Runnable Jar ..." in vietnamese.json).

I am willing to go through myself and fix the grammar bits, but I'm also curious what you think about code formatting (since #422).

@Konloch
Copy link
Owner

Konloch commented Aug 21, 2024

Hey Nick, if you join our discord so we could chat in more detail about trying to coordinate these changes. (Assuming you're not in there already, I did a quick look to try and DM you, but I didn't see you)

I think these changes are positive but they will require a lot of hands on work, I'd like to be involved in helping with these changes directly if possible.

I believe the majority of the translate inconsistencies came from myself during automatic translations (assuming the base English didn't also have the same mistake). I'd like to help you and solve these grammatical changes.

As for code formatting, that's something I would like to standardize, as well, I know @ThexXTURBOXx has resolved for us in the past but we never standardized that when we did it, so I'm sure we could adopt a standard and enforce it on the project.

Cheers, and thanks for the suggestions! Hopefully we can implement these changes soon, thanks @nick-botticelli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants