Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When cancelling an upload, it seems to still be working in the background? #236

Closed
bjhess opened this issue Dec 5, 2024 · 3 comments · Fixed by #237
Closed

When cancelling an upload, it seems to still be working in the background? #236

bjhess opened this issue Dec 5, 2024 · 3 comments · Fixed by #237

Comments

@bjhess
Copy link
Contributor

bjhess commented Dec 5, 2024

I'm not sure if this is resolvable. And it's not a huge deal, IMO. But I wanted to register it because I saw it.

After tying into the pendingAttachments capability of direct uploads, I noticed that if I cancel an upload the pendingAttachments array is still populated until [some point when it gets cleared].

Here's a video proving it (the alert happens when pendingAttachments.length > 0):

https://share.cleanshot.com/5RPZrJdf

@KonnorRogers
Copy link
Owner

Oh hang on. I believe I know the fix for this. There's an appendTransaction in Rhino that needs to clear this.

@KonnorRogers
Copy link
Owner

KonnorRogers commented Dec 5, 2024

Fixed in 0.14.2! If its still giving you problems, feel free to re-open this or open a new issue.

@bjhess
Copy link
Contributor Author

bjhess commented Dec 6, 2024

Just did a quick check and I think it's working. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants