Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrypoint in index.html not rewritten if nested or multiple entrypoints defined #25

Open
cbxp opened this issue Nov 6, 2020 · 1 comment

Comments

@cbxp
Copy link

cbxp commented Nov 6, 2020

In case of nested entrypoints, e.g. /_dist_/ui/something.js, baseFile gets only filename 'something' and not 'ui/something' to be replaced properly.

In case of multiple entrypoints, the /_dist_/ prefix is omitted from unhashedEntrypoints and isEntrypoint check always fails.

@KonnorRogers
Copy link
Owner

@cbxp i actually plan on ripping this feature out. It's brittle and error prone. There's a lot of edge cases and I think it's easier to just tell the user to read from the generated manifest.

#24 addresses it, I just haven't gotten around to making it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants