Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convertTo<>() breaks with nullable DataRows #176

Closed
Jolanrensen opened this issue Oct 5, 2022 · 0 comments
Closed

convertTo<>() breaks with nullable DataRows #176

Jolanrensen opened this issue Oct 5, 2022 · 0 comments
Assignees

Comments

@Jolanrensen
Copy link
Collaborator

@DataSchema
public data class Location(
    val name: String,
    val gps: Gps?,
)

@DataSchema
public data class Gps(
    val latitude: Double,
    val longitude: Double,
)

val locations: DataFrame<Location> = listOf(
    Location("Home", Gps(0.0, 0.0)),
    Location("Away", null),
).toDataFrame()

This is a valid DataFrame looking like:

⌌----------------------------------------------------------⌍
|  | name:String| gps:{latitude:Double?, longitude:Double?}|
|--|------------|------------------------------------------|
| 0|        Home|  { latitude:0.000000, longitude:0.0000...|
| 1|        Away|                                       { }|
⌎----------------------------------------------------------⌏

name: String
gps:
    latitude: Double?
    longitude: Double?

However:

locations.convertTo<Location>()

produces

Exception in thread "main" org.jetbrains.kotlinx.dataframe.exceptions.TypeConversionException: Failed to convert 'null' from kotlin.Double? to kotlin.Double
	at org.jetbrains.kotlinx.dataframe.impl.api.ConvertKt.convertToTypeImpl$checkNulls(convert.kt:79)
	at org.jetbrains.kotlinx.dataframe.impl.api.ConvertKt.convertToTypeImpl(convert.kt:103)
	at org.jetbrains.kotlinx.dataframe.api.ConvertKt.convertTo(convert.kt:106)
	at org.jetbrains.kotlinx.dataframe.impl.api.ConvertToKt.convertToImpl$convertToSchema(convertTo.kt:90)
	at org.jetbrains.kotlinx.dataframe.impl.api.ConvertToKt.convertToImpl$convertToSchema(convertTo.kt:99)
	at org.jetbrains.kotlinx.dataframe.impl.api.ConvertToKt.convertToImpl(convertTo.kt:126)
	at org.jetbrains.kotlinx.dataframe.api.ConvertToKt.convertTo(convertTo.kt:68)
	at org.jetbrains.kotlinx.dataframe.examples.movies.TestKt.main(test.kt:82)
	at org.jetbrains.kotlinx.dataframe.examples.movies.TestKt.main(test.kt)

It looks like it tries to instantiate a Gps when it should just provide it with null instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant