Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataColumn<Nothing>.isNumber() gives true #748

Closed
Jolanrensen opened this issue Jun 21, 2024 · 2 comments · Fixed by #795
Closed

DataColumn<Nothing>.isNumber() gives true #748

Jolanrensen opened this issue Jun 21, 2024 · 2 comments · Fixed by #795
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Jolanrensen
Copy link
Collaborator

This breaks functions like describe() which calculate the mean() and std() for isNumber columns.

image

It's similar to #724 and isComparable().

@Jolanrensen Jolanrensen added the bug Something isn't working label Jun 21, 2024
@Jolanrensen Jolanrensen added this to the Backlog milestone Jun 21, 2024
@Jolanrensen Jolanrensen self-assigned this Jun 21, 2024
@koperagen
Copy link
Collaborator

Small notice: seems strange that type is Nothing. Type of null should be Nothing?

@Jolanrensen Jolanrensen modified the milestones: Backlog, 0.14.0 Jul 29, 2024
@Jolanrensen
Copy link
Collaborator Author

Actually, technically speaking DataColumn<Nothing>.isNumber() should result in true. It's the fault of mean() and std() for not being able to give a result for an empty column. This result should likely be NaN instead of throwing an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants