Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty parentheses in signatures are redundant for enum entries #2355

Closed
vmishenev opened this issue Feb 10, 2022 · 2 comments · Fixed by #2470
Closed

Empty parentheses in signatures are redundant for enum entries #2355

vmishenev opened this issue Feb 10, 2022 · 2 comments · Fixed by #2470
Labels

Comments

@vmishenev
Copy link
Member

vmishenev commented Feb 10, 2022

Also, parentheses are absent for enum constructor in a description: http://dokka-snapshots.s3.eu-central-1.amazonaws.com/master/stdlib/c44bf54/kotlin-stdlib/kotlin.native.concurrent/-future-state/index.html

@vmishenev vmishenev added the bug label Feb 10, 2022
@IgnatBeresnev
Copy link
Member

Also, parentheses are absent for enum constructor in a decroption

Not sure what you mean, can you give some details or maybe an example? Current link is https://dokka-snapshots.s3.eu-central-1.amazonaws.com/2466-enum-entry-ordering/stdlib/6dcdfee/kotlin-stdlib/kotlin.native.concurrent/-future-state/index.html

I don't see anything wrong on that page

@vmishenev
Copy link
Member Author

vmishenev commented Apr 26, 2022

Th signature of enum constructor is enum class FutureState(val value: Int)
https://github.com/JetBrains/kotlin/blob/6a670dc5f38fc73eb01d754d8f7c158ae0176ceb/kotlin-native/runtime/src/main/kotlin/kotlin/native/concurrent/Future.kt#L13 but Dokka renders enum class FutureState
It leads to magic arguments in the entries, e.g. INVALID(0)

UPDATE:
#2497 fixes it

IgnatBeresnev added a commit that referenced this issue Apr 27, 2022
* Fix empty parentheses for no-arg enum entry

Fixes #2355

* Move parentheses punctuation inside `list` call

* Revert formatting

* Correct expected ordering of enum entries in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants