Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies between K1 and K2 #3115

Closed
vmishenev opened this issue Aug 12, 2023 · 0 comments
Closed

Fix inconsistencies between K1 and K2 #3115

vmishenev opened this issue Aug 12, 2023 · 0 comments
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888

Comments

@vmishenev
Copy link
Member

vmishenev commented Aug 12, 2023

Some existing unit tests are inconsistent with K2:

and so on. See other muted tests by @OnlyDescriptors. All @OnlyDescriptors applications have a reason parameter.

Insignificant ones:

  • In K2, the name of the accessors parameter is value: isFoo(), setFoo(String isFoo) vs isFoo(), setFoo(String value). (test JavadocAccessorNamingTest.verifySpecialIsRuleIsApplied). It affects only as-java and javadoc plugins.
@vmishenev vmishenev added the bug label Aug 12, 2023
@vmishenev vmishenev changed the title Fix inconsistencies in K1 and K2 Fix inconsistencies between K1 and K2 Aug 13, 2023
@IgnatBeresnev IgnatBeresnev added the topic: K2 Issues / PRs that are related to the K2 migration. See #2888 label Oct 13, 2023
@vmishenev vmishenev closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

No branches or pull requests

2 participants