Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K2] Incorrect link for methods with parameters in Java stdlib #3355

Closed
atyrin opened this issue Nov 16, 2023 · 2 comments · Fixed by #3501
Closed

[K2] Incorrect link for methods with parameters in Java stdlib #3355

atyrin opened this issue Nov 16, 2023 · 2 comments · Fixed by #3501
Assignees
@vmishenev
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone
Dokka 2.0.0

Comments

@atyrin
Copy link
Contributor

atyrin commented Nov 16, 2023 

/**
 * @see [java.applet.AppletContext.showDocument] reference
 */
class X

For K1 link was: https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/applet/AppletContext.html#showDocument(java.net.URL)

For K2, the parameter is handled as nullable: https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/applet/AppletContext.html#showDocument(java.net.URL?)

That leads to incorrect navigation to javadoc.

Installation

  • Dokka version: 1.9.20

Parent: #3328
@atyrin atyrin added the bug label Nov 16, 2023
@atyrin
Copy link
Contributor Author

atyrin commented Nov 16, 2023

Relates to #3351 (but that issue exists in K1 as well)

@atyrin atyrin added the topic: K2 Issues / PRs that are related to the K2 migration. See #2888 label Nov 17, 2023
@IgnatBeresnev IgnatBeresnev mentioned this issue Dec 12, 2023
Open
31 tasks
@vmishenev vmishenev self-assigned this Feb 18, 2024
@vmishenev vmishenev linked a pull request Feb 20, 2024 that will close this issue
[K2] Fix nullable parameters in DRI and Javadoc links #3501
Merged
@vmishenev
Copy link
Member

Also, it is related to #2357

@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmishenev vmishenev

Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Milestone
Dokka 2.0.0
Development

Successfully merging a pull request may close this issue.

[K2] Fix nullable parameters in DRI and Javadoc links Kotlin/dokka
3 participants
@atyrin @vmishenev @IgnatBeresnev