Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap long signatures dynamically based on taken client width #2659

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Wrap long signatures dynamically based on taken client width #2659

merged 5 commits into from
Sep 21, 2022

Conversation

IgnatBeresnev
Copy link
Member

See #2576

@IgnatBeresnev IgnatBeresnev mentioned this pull request Sep 8, 2022
Closed
vmishenev
vmishenev approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@vmishenev vmishenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but the content is shifted after I resize a window.

@IgnatBeresnev
Copy link
Member Author

IgnatBeresnev commented Sep 20, 2022 •
edited
Loading

@vmishenev updated the PR. Got rid of timeout logic.

JFYI, may be useful in the future for these kinds of things: turns out, in Chrome's dev menu, under Network tab, you can enable network throttling, so resources take much more time to load. With this enabled, the issue is easily reproducible even locally.

@IgnatBeresnev IgnatBeresnev merged commit 879d4f2 into master Sep 21, 2022
@IgnatBeresnev IgnatBeresnev deleted the dynamic-signature-wrapping branch September 21, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmishenev vmishenev vmishenev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgnatBeresnev @vmishenev