move POM config to maven-publish convention plugin #2946
Merged
+29
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infrastructureEverything related to builds tools, CI configurations and project tooling
Continue migrating the build logic to use convention plugins #2703
It is a small part of simplifying the logic in
build-logic/src/main/kotlin/org/jetbrains/publication.kt
Impact
This change has only one change: I removed the
afterEvaluate {}
logic for configuring the Dokka Gradle Plugin POM. The result is that the POM is now different.(the PR is on the left, master is on the right)
I'd like to be able to avoid this, but I think that improving the build logic is better than trying to edit a POM that most people won't realise even exists!
Testing
I have tested this by
dokka_version
to be1.8.20
(just so long as it's not a SNAPSHOT - otherwise the comparison below is impossible)./gradlew publishAllPublicationsToMavenProjectLocalRepository
$rootDir/build/maven-project-local
to$rootDir/build/maven-project-local-tmp
./gradlew publishAllPublicationsToMavenProjectLocalRepository
$rootDir/build/maven-project-local
with$rootDir/build/maven-project-local-tmp