Add "sealed" keyword to sealed interface signatures #3001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnatBeresnev
commented
May 19, 2023
Comment on lines
+1067
to
+1083
| private fun MemberDescriptor.modifier(): KotlinModifier { | ||
| val isInterface = this is ClassDescriptor && this.kind == ClassKind.INTERFACE | ||
| return if (isInterface) { | ||
| when (modality) { | ||
| // modifiers other than "sealed" are redundant for interfaces | ||
| Modality.SEALED -> KotlinModifier.Sealed | ||
| else -> KotlinModifier.Empty | ||
| } | ||
| } else { | ||
| when (modality) { | ||
| Modality.FINAL -> KotlinModifier.Final | ||
| Modality.SEALED -> KotlinModifier.Sealed | ||
| Modality.OPEN -> KotlinModifier.Open | ||
| Modality.ABSTRACT -> KotlinModifier.Abstract | ||
| else -> KotlinModifier.Empty | ||
| } | ||
| } |
There was a problem hiding this comment.
This particular bit could certainly be improved, but it's going to be re-written to K2 anyway, and I'd like to minimize merge conflicts with the refactoring I'm doing in a neighbouring branch.
vmishenev
approved these changes
Jun 23, 2023
| private fun PsiModifierListOwner.getModifier(): JavaModifier { | ||
| val isInterface = this is PsiClass && this.isInterface | ||
| if (isInterface) { | ||
| return JavaModifier.Empty // all Java modifiers are redundant for interfaces |
There was a problem hiding this comment.
Nitpicking: The comment is a little confusing. Interfaces can have an access modifier.
|
This PR is too outdated, it's easier to re-implement it than trying to rebase and merge the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2994