Fix overflow of long underscore separated names in HTML #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seelchen
force-pushed
the
html-word-overflow
branch
2 times, most recently
from
eb4c09a
to
afdc289
Compare
seelchen
changed the title
|
Hi @IgnatBeresnev, could you please review my PR if you have time? |
|
@seelchen hi! thank you for the contribution, and sorry for the delay with review. The two PRs you've submitted cover a pretty wide area of Dokka, so we need some extra time to make sure it's aligned with Dokka's design requirements, and that it doesn't break any corner cases |
seelchen
force-pushed
the
html-word-overflow
branch
from
afdc289
to
d0dbcd2
Compare
|
Hi @IgnatBeresnev and @whyoleg, are there any updates on the review of this PR? |
whyoleg
requested changes
Mar 27, 2024
...ts/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/htmlFormatingUtils.kt
Show resolved
Hide resolved
...ts/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/htmlFormatingUtils.kt
Outdated
Show resolved
Hide resolved
seelchen
force-pushed
the
html-word-overflow
branch
from
d0dbcd2
to
8fc8f96
Compare
whyoleg
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes underscore separated names breakable after each underscore similar to how names separated by dots are rendered.
Resolves #3093.