[K1] Handle exception for recursive type aliases #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
commented
Apr 24, 2024
| DTypeAlias( | ||
| dri = DRI.from(this@with), | ||
| name = name.asString(), | ||
| type = defaultType.toBound(), | ||
| type = defaultType?.toBound() ?: UnresolvedBound(name.asString()), |
There was a problem hiding this comment.
There is an alternative way: type = GenericTypeConstructor(dri = dri, projections = generics.await().map { it.variantTypeParameter }) like in K2. I would like to have the old logic in K1 to discover the difference between the two ways.
vmishenev
force-pushed
the
vmishenev/3572-Avoid-failing-Dokka-generation-in-jvm+androidJvm-projects
branch
from
23a27cc
to
02cb122
Compare
Updated the `DefaultDescriptorToDocumentableTranslator` to avoid throwing an exception when encountering recursive type aliases. The changes ensure that the `defaultType` is safely accessed. Also, added a new test for this scenario to avoid regression in the future.
vmishenev
force-pushed
the
vmishenev/3572-Avoid-failing-Dokka-generation-in-jvm+androidJvm-projects
branch
from
02cb122
to
35a470d
Compare
IgnatBeresnev
approved these changes
Apr 25, 2024
...analysis/kotlin/descriptors/compiler/translator/DefaultDescriptorToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
whyoleg
approved these changes
Apr 25, 2024
…n/kotlin/org/jetbrains/dokka/analysis/kotlin/descriptors/compiler/translator/DefaultDescriptorToDocumentableTranslator.kt Co-authored-by: Ignat Beresnev <ignat.beresnev@jetbrains.com>
vmishenev
deleted the
vmishenev/3572-Avoid-failing-Dokka-generation-in-jvm+androidJvm-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
DefaultDescriptorToDocumentableTranslatorto avoid throwing an exception when encountering recursive type aliases. The changes ensure that thedefaultTypeis safely accessed. Also, added a new test for this scenario to avoid regression in the future.