-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native benchmark fails on 0.4.10 #173
Comments
@CharlieTap I tried to reproduce the problem and the build failed with two different issues none of which match the summary you posted above. Could you please share your build log via The two aforementioned issues I faced while running the benchmarks are:
|
I've posted a fresh branch here with it failing here, with the extra mode the removed (this should probably be documented as the annotations are copied from JMH so I won't be the last to run into this) https://github.com/CharlieTap/cachemap/tree/failing-native-benchmark And also heres a scan: https://scans.gradle.com/s/lazrbivpp5g7s With regards to kotlin compiler embeddable I'm not sure what you're referring to as 1.8.20 is not a dependency of my project at all? |
@CharlieTap thanks for posting the scan!
It's a transitive dependency for coroutines. In your case it seems to be the similar issue, but with serialization. I'm not quite sure why it's happening (Gradle reports that 1.9.* versions of these artifacts should be used instead of 1.8.*), I'll check what could be done there. |
Filed #174 for the issue with multiple benchmark modes. |
Looking at the benchmark module, it's from the kotlinter:
|
@CharlieTap could you please try placing the following block before
|
Ohh thats fixes it! So both ktlint and this library use the embedded compiler and its picking the 1st one loaded on the classpath? Is there a fix for this other than forcing the version like you provided above? |
The problem is that benchmarks plugin declares embedded compiler as a compile-only dependency (and there's a good reason for doing that) and that may need to use of incompatible compiler version in runtime. |
There is an ongoing effort from the Build Tools team to resolve this issue: https://youtrack.jetbrains.com/issue/KT-66764 |
I'm running:
Kotlin 1.9.2
OS: Sonoma
CPU: Apple M1 Max
Gradle: 8.5
You can recreate by running build on this branch:
https://github.com/CharlieTap/cachemap/tree/failing-benchmark
I get the following:
The text was updated successfully, but these errors were encountered: