Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extensions to read/write unsigned byte arrays #328

Closed
fzhinkin opened this issue May 21, 2024 · 1 comment
Closed

Provide extensions to read/write unsigned byte arrays #328

fzhinkin opened this issue May 21, 2024 · 1 comment

Comments

@fzhinkin
Copy link
Collaborator

There are several extensions allowing to read/write byte arrays, as well as extensions operating on unsigned numbers, but there are no extensions working with unsigned byte arrays.

It's always an option to convert a regular byte array to an unsigned one, but doing so adds unnecessary overhead.

We should consider providing extensions to read and write unsigned byte arrays directly.

The same is true for ByteStrings (at least, for their construction).

@fzhinkin
Copy link
Collaborator Author

fzhinkin commented Oct 2, 2024

That part is wrong in presence of asByteArray/asUByteArray functions:

It's always an option to convert a regular byte array to an unsigned one, but doing so adds unnecessary overhead.

There were no demand for this functions in form of questions / additional requests / comments in this issue, so for now I'm closing it. The decision could always be reconsidered.

@fzhinkin fzhinkin closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant