Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera source filter toggle? #69

Open
nickfujita opened this issue Oct 30, 2023 · 6 comments
Open

Camera source filter toggle? #69

nickfujita opened this issue Oct 30, 2023 · 6 comments

Comments

@nickfujita
Copy link

Is it possible to toggle or edit the filters on a given source?

@nickfujita nickfujita changed the title Camera source filter: Camera source filter? Oct 30, 2023
@nickfujita nickfujita changed the title Camera source filter? Camera source filter toggle? Oct 30, 2023
@bzeeman
Copy link

bzeeman commented Nov 19, 2023

This would be great.

In the middle of a performance I tried remoting into my computer to edit a filter and that often causes the video inputs to freeze in the latest OBS.

@Kounex
Copy link
Owner

Kounex commented Nov 27, 2023

Filters are complex, not sure if I want to open that rabbit hole. Will have to check if it's feasible!

@Kounex
Copy link
Owner

Kounex commented Nov 30, 2023

Okay hear me out, for now enabling/disabling filters is something I was able to implement without falling into the rabbit hole. Updating the filters itself is a bit more tricky because all filters are different regarding min/max value, numbers or boolean and so on. Maybe thats somethung I might implement someday, but at least toggling will be able! 😄

image

Still working on the update itself - will update this issue once I pushed it to the stores!

@nickfujita
Copy link
Author

That's amazing news! Just being able to toggle filters would be a big win. Thank you so much for looking into this 🙏🏼

@Kounex
Copy link
Owner

Kounex commented Dec 4, 2023

Ah f***, couldn't resist trying it out and got a version working which is good enough to include so it's possible to edit filters 😂 The WebSocket API is not optimal for this (like filter setting names are not present, some default values are not exposed and dropdown values are treated like text etc.) but should be fine for those who want it!

image

Will be included in the next update!

@yesuraj130
Copy link

If possible, can you please release apk including this feature.
(Last released version 3.2.0 on May 2023, 10 months before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants