Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t hang with NotoColorEmoji SVG #1935

Closed
pareshbalar opened this issue Aug 7, 2023 · 6 comments
Closed

Don’t hang with NotoColorEmoji SVG #1935

pareshbalar opened this issue Aug 7, 2023 · 6 comments
Assignees
@liZe
Milestone
60.0

Comments

@pareshbalar
Copy link

pareshbalar commented Aug 7, 2023 •
edited
Loading

Hi,

I am using the latest version of Weasyprint and using it in docker.

Also, I have installed all the Google fonts into my docker.

Here is my docker file config to install Weasyprint and Google fonts.

FROM node:latest

RUN apt-get update && apt-get install -y pipx && \
    pipx install weasyprint && pipx ensurepath && \
    mv /root/.local/bin/* /usr/bin/

RUN wget https://github.com/google/fonts/archive/main.tar.gz -O gf.tar.gz && \
  tar -xf gf.tar.gz && \
  mkdir -p /usr/share/fonts/truetype/google-fonts && \
  find $PWD/fonts-main/ -name "*.ttf" -exec install -m644 {} /usr/share/fonts/truetype/google-fonts/ \; || return 1 && \
  rm -f gf.tar.gz && \
  rm -rf $PWD/fonts-main && \
  rm -rf /var/cache/* && \
  fc-cache -f

Here is the Weasyprint version & config

WeasyPrint version: 59.0
Python version: 3.11.2
Pydyf version: 0.7.0
Pango version: 15012

Here is my HTML content.

<!DOCTYPE html>
<html>
  
<head>
    <meta charset="UTF-8">
</head>
  
<body>
  
    <h1>Emoji List:</h1>
  
    <p>Grinning face : <span> 😀 </span> </p>
    <p>Face having tears of joy : <span> 😂 </span> </p>
    <p>Fire : <span> 🔥 </span> </p>
    <p>Thumbs up : <span> 👍 </span> </p>
    <p>Bell : <span> 🔔 </span> </p>
  
</body>
  
</html>

When I am trying to convert this HTML file to PDF using Weasyprint, the entire process hangs and I need to restart the server in order to recover it.

Command
weasyprint --verbose emoji.html out.pdf

Output

INFO: Step 1 - Fetching and parsing HTML - emoji.html
INFO: Step 3 - Applying CSS
INFO: Step 4 - Creating formatting structure
INFO: Step 5 - Creating layout - Page 1
INFO: Step 6 - Creating PDF

It is not creating PDF after step 6.

I tried removing the google fonts from the docker and It is working fine but not printing Emojis.

Please help.
@pareshbalar
Copy link
Author

Hi,
Up on debugging this issue more, I have found that It's the size of the font file of Emoji is creating an issue.

See the below screenshot.
image

The size of the Google Emoji fonts are 56MB and 23MB and that is causing this issue.

If I remove these two fonts, the system is able to convert HTML To PDF but color emojis are not displayed. It's printing black & white emojis.

Any suggestions on how can we print color emojis in PDF?

@liZe
Copy link
Member

liZe commented Aug 9, 2023

It’s a known problem. A quick fix is just to use the version proposed by your distribution: apt install fonts-noto-color-emoji.

If it’s OK for you, we can close this issue.

@liZe
Copy link
Member

liZe commented Aug 9, 2023

(Using this font system-wide actually breaks many applications, so WeasyPrint is not the only one having trouble with this terrible file that includes a stupidly large amount of SVG images…)

@liZe
Copy link
Member

liZe commented Aug 9, 2023

Actually, there may be a way to fix this. Let’s keep this issue open.

@liZe liZe changed the title Server hang when installing all google fonts and there is Emojis in HTML Don’t hang with NotoColorEmoji SVG Aug 9, 2023
@liZe liZe closed this as completed in 6977e79 Aug 9, 2023
@liZe
Copy link
Member

liZe commented Aug 9, 2023

OK, that’s fixed.

Here’s the truth: this font is awful. It uses a 14MB SVG (!!!) and lets users automatically parse, change and render it differently for each glyph. It should be possible to do something smart to avoid reparsing this SVG each time a new glyph is found, but I’m not sure that we want to spend some time on this. On my computer, when using this font, even browsers lag when they first try to display an emoji.

So, that’s slow, but it doesn’t crash and renders quite well (when SVG is not too complicated).

If someone reads this thread: just use the raster version of NotoColorEmoji, it’s packaged with your Linux distribution.

@liZe liZe added this to the 60.0 milestone Aug 9, 2023
@liZe liZe self-assigned this Aug 9, 2023
@pareshbalar
Copy link
Author

It’s a known problem. A quick fix is just to use the version proposed by your distribution: apt install fonts-noto-color-emoji.

If it’s OK for you, we can close this issue.

Yes, that worked for me.

I have removed Google Noto fonts and have installed them using
apt install fonts-noto

and that worked :)

Thanks 👍

netbsd-srcmastr referenced this issue in NetBSD/pkgsrc Oct 15, 2023
@kleink
py-weasyprint: Update to 60.1.
a5fb891 
Version 60.1
------------

Released on 2023-09-29.

Bug fixes:

* `#1973 <https://github.com/Kozea/WeasyPrint/issues/1973>`_:
  Fix crash caused by wrong UTF-8 indices


Version 60.0
------------

Released on 2023-09-25.

New features:

* `#1903 <https://github.com/Kozea/WeasyPrint/issues/1903>`_:
  Print form fields
* `#1922 <https://github.com/Kozea/WeasyPrint/pull/1922>`_:
  Add support for textLength and lengthAdjust in SVG text elements
* `#1965 <https://github.com/Kozea/WeasyPrint/issues/1965>`_:
  Handle <wbr> tag
* `#1970 <https://github.com/Kozea/WeasyPrint/pull/1970>`_:
  Handle y offset of glyphs
* `#1909 <https://github.com/Kozea/WeasyPrint/issues/1909>`_:
  Add a --timeout option

Bug fixes:

* `#1887 <https://github.com/Kozea/WeasyPrint/pull/1887>`_:
  Fix footnote-call displayed incorrectly for some fonts
* `#1890 <https://github.com/Kozea/WeasyPrint/pull/1890>`_:
  Fix page-margin boxes layout algorithm
* `#1908 <https://github.com/Kozea/WeasyPrint/pull/1908>`_:
  Fix IndexError when rendering PDF version 1.4
* `#1906 <https://github.com/Kozea/WeasyPrint/issues/1906>`_:
  Apply text transformations to first-letter pseudo elements
* `#1915 <https://github.com/Kozea/WeasyPrint/pull/1915>`_:
  Avoid footnote appearing before its call
* `#1934 <https://github.com/Kozea/WeasyPrint/pull/1934>`_:
  Fix balance before "column-span: all"
* `#1935 <https://github.com/Kozea/WeasyPrint/issues/1935>`_:
  Only draw required glyph with OpenType-SVG fonts
* `#1595 <https://github.com/Kozea/WeasyPrint/issues/1595>`_:
  Don’t draw clipPath when defined after reference
* `#1895 <https://github.com/Kozea/WeasyPrint/pull/1895>`_:
  Don’t ignore min-width when computing cell size
* `#1899 <https://github.com/Kozea/WeasyPrint/pull/1899>`_:
  Fix named pages inheritance
* `#1936 <https://github.com/Kozea/WeasyPrint/pull/1936>`_:
  Avoid page breaks caused by children of overflow hidden boxes
* `#1943 <https://github.com/Kozea/WeasyPrint/issues/1943>`_:
  Use bleed area for page’s painting area
* `#1946 <https://github.com/Kozea/WeasyPrint/issues/1946>`_:
  Use margin box of children to define available width for leaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liZe liZe

Labels
None yet
Projects
None yet
Milestone
60.0
Development

No branches or pull requests
2 participants
@liZe @pareshbalar