Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary key repr not escaped. #157

Open
amcgregor opened this issue Dec 6, 2022 · 0 comments
Open

Dictionary key repr not escaped. #157

amcgregor opened this issue Dec 6, 2022 · 0 comments

Comments

@amcgregor
Copy link

Seems related to the very old #81 in that certain values (dictionary keys, in our case) are not escaped.

Use of repr() as keys results in apparently no keys. (Web inspector shows that they're being interpreted as HTML.)

MCVE

Enter the following in a presented interactive REPL or traceback:

{'<a href="about:blank">Testing</a>': 'value'}

Or, attempt to use the REPR of a class as keys:

{repr(type): 'value'}

This was exceptionally confusing when our plugin registry showed an empty string for every key.

Screenshot

Screenshot 2022-12-06 at 10 36 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant