Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vaadin-Vertx Version 1.0.0 #761

Open
Dudeplayz opened this issue Jan 8, 2019 · 2 comments
Open

Upgrade to Vaadin-Vertx Version 1.0.0 #761

Dudeplayz opened this issue Jan 8, 2019 · 2 comments

Comments

@Dudeplayz
Copy link

Hi,
It would be nice to upgrade the vaadin-vertx libary to the newest version. Some adjustments are necessary. I would do it in a pull request but i am not that good in kotlin.

A vaadin version upgrade could be also useful.

@davidsowerby
Copy link
Collaborator

davidsowerby commented Jan 9, 2019

I would be happy to accept a PR in Java rather than Kotlin, but in this case that probably is not practical.

I have not yet looked at what changes need to be made. Could you share what you think would be required?

@Dudeplayz
Copy link
Author

Mainly the sockjs implementation is now seperated from the project to support vaadin8 and vaadin10
independently. Thats why some classpaths have changed which results in exceptions if the version is raised. Because my kotlin knowledge is very fresh im not sure if the pushconnection access is very different. Some things have changed internally but the API could be mostly the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants