Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty table if print_timer is called in project outside module that uses the global timer #83

Closed
henriquebecker91 opened this issue Apr 17, 2020 · 3 comments · Fixed by #84
Closed

Empty table if print_timer is called in project outside module that uses the global timer #83

henriquebecker91 opened this issue Apr 17, 2020 · 3 comments · Fixed by #84

Comments

@henriquebecker91
Copy link

This file (timer_outputs_0_5_4_bug.tar.gz) has a small reproducer script. I found this error because my code began to give me completely empty tables the moment I updated to version 0.5.4 (having not changed anything related to TimerOutputs for some time now). I am not sure what exactly causes that (as I have zero experience with macros), but I suspect the first lines changed by this commit. Also, maybe I have not understood how the package should work and this was expected, but as it was a sudden change from the last version, and was not announced anywhere, I do believe it is unintended.
@KristofferC
Copy link
Owner

Yeah, it wasn't meant to change anything. Thanks for the report, will look at it.

@henriquebecker91
Copy link
Author

Thanks for the fast answer!

@KristofferC KristofferC mentioned this issue Apr 22, 2020
Merged
@KristofferC
Copy link
Owner

I believe #84 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@KristofferC @henriquebecker91