Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check if document.getElementById ("lang") exists at all, resulting in a type error #234

Open
cboulanger opened this issue Jun 18, 2015 · 0 comments

Comments

@cboulanger
Copy link

Hi,

Thank you for NN-Forum. I am using it successfully in a plugin for a bibliographic application:

https://github.com/cboulanger/bibliograph/tree/master/bibliograph/plugins/nnforum

I had to tweak it a liitle bit to make it work for me(sorry, didn't clone it, just used the zip, but marked all the changes)

There is one thing that striked me as a bug, see

https://github.com/cboulanger/bibliograph/blob/master/bibliograph/plugins/nnforum/services/www/themes/greyscale/index.html#L212

document.getElementById ("lang") is not present by default, thereby resulting in a type error. I had to add if ( document.getElementById ("lang") ) here and in the other theme files.

Best,
Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant