Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excess over mintFeeAmount not returned #113

Open
dckc opened this issue Dec 27, 2023 · 0 comments
Open

excess over mintFeeAmount not returned #113

dckc opened this issue Dec 27, 2023 · 0 comments

Comments

@dckc
Copy link
Contributor

dckc commented Dec 27, 2023

I'm doing some testing and I didn't have the mintFeeAmount handy, so I tried 50IST. Minting worked, but it took all 50IST. Some experimentation suggests the mintFeeAmount is 5IST, so I would expect to get 45IST back.

But the contract computes the platform / royalty split on the whole give.Price, not just mintFeeAmount:

const royaltyFee = multiplyBy(give.Price, mintRoyaltyRate);
const platformFee = multiplyBy(give.Price, mintPlatformFeeRate);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant