Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Definition for TODO - Performance Comparison #1

Closed
raphaeleidus opened this issue Jun 21, 2019 · 4 comments
Closed

Question: Definition for TODO - Performance Comparison #1

raphaeleidus opened this issue Jun 21, 2019 · 4 comments

Comments

@raphaeleidus
Copy link

It would be great to have some thoughts on what a performance comparison should look like.
Is it timing around running a bunch of JS code?
Is it timing around making a bunch of bridge module calls?
Is it taking an app and comparing the scroll performance?
Some mix of all of the above?

If you can start with defining that TODO a little more clearly I might be able to start the comparison and send in a PR.

@Kudo
Copy link
Owner

Kudo commented Jun 22, 2019

@raphaeleidus Thank you for the good question.

I used to measure by the scripts from jsc-android-buildscripts.
https://github.com/react-native-community/jsc-android-buildscripts/tree/master/measure
There are some pure JS benchmarks and two React Native rendering cases.

However, we are not sure if that benchmarks fit with real apps.
If you have some idea, maybe it is worth to create a proposal at https://github.com/react-native-community/discussions-and-proposals.
Probably "Official benchmark for React Native app".

@Kudo
Copy link
Owner

Kudo commented Jul 25, 2019

Just to update that I had some result already.
https://github.com/Kudo/react-native-js-benchmark
I am going to close this issue and feel free to open new issue at that repo if you have any further questions.
Thank you so much.

@Kudo Kudo closed this as completed Jul 25, 2019
@sapjax
Copy link

sapjax commented Jul 29, 2019

@Kudo
According to the result, v8 7.5.1 arm32 JIT has the best performance?

@Kudo
Copy link
Owner

Kudo commented Jul 29, 2019

@sapjax Yes, and it should be expected.
jsc-android we only turn on Baseline JIT (and disabled DFG JIT and FTL JIT).
Hermes, on the other hand, does not have JIT.

Well, memory usage / CPU / binary size might be another story compared with performance.
I will add memory / CPU benchmark if I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants